Migrate async_html from dart:html to package:web
#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@devoncarew I'm guessing there might not be anyone that maintains this repository. Could you help me find reviewers for this and the other PRs I opened recently? No rush on them though :) Thanks! |
Contributor
I'll take a pass through them and may cc additional people as necessary. FYI that this is one that rolls into google3; there may be some latency in terms of knowing whether the change(s) stick. |
Contributor
|
The failing firefox tests - while super annoying - are known and tracked here: #292. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 24, 2025
test (https://github.com/dart-lang/test/compare/17609bf..a833663): a833663e 2025-02-18 Kevin Moore [test] ignore deprecated pkg:js (for now) (dart-lang/test#2458) webdriver (https://github.com/google/webdriver.dart/compare/e84e9cc..b4fd859): b4fd859 2025-02-22 Parker Lougheed Close HTTP clients if creating async session fails (google/webdriver.dart#318) bc8b61c 2025-02-22 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#319) 90dc2aa 2025-02-22 Devon Carew Update ci.yaml (google/webdriver.dart#320) 0efb41b 2025-02-21 Parker Lougheed Migrate async_html from `dart:html` to `package:web` (google/webdriver.dart#315) 6085884 2025-02-21 Parker Lougheed Update and tighten dev dependency constraints (google/webdriver.dart#317) Change-Id: Ife06e61ae9f23f0d0715edceb9728ce3e4ba04de Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411761 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration uses the deprecated
HttpRequesthelper(s) frompackage:webso it doesn't need to reimplement any handling. Usages of this HTML client should likely migrate to #314.Resolves #312