Fixed get_ad_unit_hierarchy.py #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you store the parent ad unit on the variable "root_ad_unit" (line 55), you are actually storing an array of size 1 which contains the ad unit. That causes the code to fail at line 74 ("if root_ad_unit['id'] in ad_unit_tree:"), because "root_ad_unit" is not the object itself, is the array of size 1 containing the object.
To prevent that, I've added a [0] at line 55 so you are storing the object instead an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you store the parent ad unit on the variable
root_ad_unit(line 55), you are actually storing an array of size 1 which contains the ad unit. That causes the code to fail at line 74 (if root_ad_unit['id'] in ad_unit_tree:), becauseroot_ad_unitis not the object itself, is the array of size 1 containing the object.To prevent that, I've added a [0] at line 55 so you are storing the object instead an array.