Skip to content

Fixes removal of non-exemptable operations in example #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes removal of non-exemptable operations in example #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions examples/adwords/v201506/error_handling/handle_policy_violation_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def main(client, ad_group_id):
operation_index = re.findall(r'operations\[(.*)\]\.',
error['fieldPath'])
if operation_index:
operation = operations[int(operation_index[0])]
operation_index = int(operation_index[0])
operation = operations[operation_index]
print ('Ad with headline \'%s\' violated %s policy \'%s\'.' %
(operation['operand']['ad']['headline'],
'exemptable' if error['isExemptable'] else 'non-exemptable',
Expand All @@ -86,13 +87,15 @@ def main(client, ad_group_id):
operation['exemptionRequests'].append({
'key': error['key']
})
else:
# Remove non-exemptable operation
print 'Removing the operation from the request.'
operations.delete(operation)
else:
# Remove non-exemptable operation
print 'Removing the operation from the request.'
operations[operation_index] = None # Defer changing the size of the list
else:
# Non-policy error returned, re-throw exception.
raise e
# Remove the non-exemptable operations
operations = [op for op in operations if op is not None]

# Add these ads. Disable "validate only" so the ads will get created.
client.validate_only = False
Expand Down
13 changes: 8 additions & 5 deletions examples/adwords/v201509/error_handling/handle_policy_violation_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def main(client, ad_group_id):
operation_index = re.findall(r'operations\[(.*)\]\.',
error['fieldPath'])
if operation_index:
operation = operations[int(operation_index[0])]
operation_index = int(operation_index[0])
operation = operations[operation_index]
print ('Ad with headline \'%s\' violated %s policy \'%s\'.' %
(operation['operand']['ad']['headline'],
'exemptable' if error['isExemptable'] else 'non-exemptable',
Expand All @@ -86,13 +87,15 @@ def main(client, ad_group_id):
operation['exemptionRequests'].append({
'key': error['key']
})
else:
# Remove non-exemptable operation
print 'Removing the operation from the request.'
operations.delete(operation)
else:
# Remove non-exemptable operation
print 'Removing the operation from the request.'
operations[operation_index] = None # Defer changing the size of the list
else:
# Non-policy error returned, re-throw exception.
raise e
# Remove the non-exemptable operations
operations = [op for op in operations if op is not None]

# Add these ads. Disable "validate only" so the ads will get created.
client.validate_only = False
Expand Down