This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: adds unit tests for sync and async reads of a pipeline transformation #1663
Merged
kevkim-codes merged 25 commits intogoogleapis:mainfrom Oct 25, 2024
Merged
feat: adds unit tests for sync and async reads of a pipeline transformation #1663kevkim-codes merged 25 commits intogoogleapis:mainfrom
kevkim-codes merged 25 commits intogoogleapis:mainfrom
Conversation
leahecole
suggested changes
Oct 2, 2024
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
A couple of overall pieces of feedback:
- I think a test should also be added to the test application that does this
- I know our problem before was the test timing out because "done" was never called, but also make sure it's possible for it to fail and to fail LOUDLY :)! It might in its current state, but it might not , which is why I added those notes about "done" and the errors
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Contributor
Author
|
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
kevkim-codes
changed the title
kevkim-codes
changed the title
|
Warning: This pull request is touching the following templated files:
|
leahecole
previously requested changes
Oct 21, 2024
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
Please add the compodoc stuff as a separate pr!
leahecole
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
leahecole
reviewed
Oct 21, 2024
leahecole
reviewed
Oct 21, 2024
Contributor
Author
|
kevkim-codes
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
leahecole
approved these changes
Oct 24, 2024
kevkim-codes
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered there may be some unit test coverage needed to test pipeline transformations during a Cloud Bigtable feature PR (googleapis/nodejs-bigtable#1494).