Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes the Next method in rows.go by caching column types and utilizing direct column decoding, which minimizes the creation of intermediate GenericColumnValue objects. A potential nil pointer dereference was identified in the Next method if r.colTypes is accessed after a failed metadata initialization; it is recommended to add a check to handle this state safely.
Remove the intermediate step of first decoding a value to a GenericColumnValue, and then into the Go type that should be returned. This reduces the number of memory allocations needed to decode query results.
97e6f09 to
5198318
Compare
rahul2393
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the intermediate step of first decoding a value to a GenericColumnValue, and then into the Go type that should be returned. This reduces the number of memory allocations needed to decode query results.
This is also needed for implementing https://pkg.go.dev/database/sql/driver#RowsColumnTypeScanType.
(Note: The 'proto' option in the above table is the option where the row is not decoded at all, but just returns the proto value. That part was not changed in this pull request.)