Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rows.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package spannerdriver

import (
"database/sql/driver"
"fmt"
"io"
"sync"

Expand Down Expand Up @@ -265,7 +266,11 @@ func (r *rows) Next(dest []driver.Value) error {
return err
}
dest[i] = v
default:
return fmt.Errorf("unsupported element type ARRAY<%v>", col.Type.ArrayElementType.Code)
}
default:
return fmt.Errorf("unsupported element type %v", col.Type.Code)
}
// TODO: Implement struct
}
Expand Down
38 changes: 38 additions & 0 deletions rows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

"cloud.google.com/go/spanner"
sppb "cloud.google.com/go/spanner/apiv1/spannerpb"
"google.golang.org/protobuf/types/known/structpb"
)

type testIterator struct {
Expand Down Expand Up @@ -81,6 +82,9 @@ func TestRows_Next(t *testing.T) {
if err == io.EOF {
break
}
if err != nil {
t.Fatal(err)
}
row := make([]driver.Value, 3)
copy(row, dest)
values = append(values, row)
Expand Down Expand Up @@ -109,3 +113,37 @@ func TestRows_Next(t *testing.T) {
}
}
}

func TestRows_Next_Unsupported(t *testing.T) {
unspecifiedType := &sppb.Type{Code: sppb.TypeCode_TYPE_CODE_UNSPECIFIED}

it := testIterator{
metadata: &sppb.ResultSetMetadata{
RowType: &sppb.StructType{
Fields: []*sppb.StructType_Field{
{Name: "COL1", Type: unspecifiedType},
},
},
},
rows: []*spanner.Row{
newRow(t, []string{"COL1"}, []any{
spanner.GenericColumnValue{
Type: unspecifiedType,
Value: &structpb.Value{},
},
}),
},
}

rows := rows{it: &it}

dest := make([]driver.Value, 1)
err := rows.Next(dest)
if err == nil {
t.Fatal("expected an error, but got nil")
}
const expectedError = "unsupported element type TYPE_CODE_UNSPECIFIED"
if err.Error() != expectedError {
t.Fatalf("expected error %q, but got %q", expectedError, err.Error())
}
}
Loading