Skip to content

Conversation

@aakashanandg
Copy link
Contributor

@aakashanandg aakashanandg commented Oct 30, 2025

chore(ruby): Add native gem workflow for Ruby wrapper

@aakashanandg aakashanandg requested a review from a team as a code owner October 30, 2025 11:10
@aakashanandg aakashanandg force-pushed the test-release-workflow branch 3 times, most recently from 79ff991 to 60272f8 Compare October 31, 2025 08:50
name: Build and Publish Native Gem

on:
release:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should remove this trigger for now. We don't want to trigger this workflow when a release of database/sql is created, and that is what would happen here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.21'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a relatively old version of Go. Is that intentional? Otherwise, it should probably be updated to 1.25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@@ -1,44 +1,82 @@
# Copyright 2025 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed accidently. Reverting this change.

@aakashanandg aakashanandg force-pushed the test-release-workflow branch 2 times, most recently from b885bb7 to e2a1d71 Compare October 31, 2025 10:24
@aakashanandg aakashanandg force-pushed the test-release-workflow branch from e2a1d71 to fa5c926 Compare October 31, 2025 10:31
@olavloite olavloite changed the title feat(ruby): Add native gem workflow for Ruby wrapper chore(ruby): Add native gem workflow for Ruby wrapper Oct 31, 2025
@aakashanandg aakashanandg merged commit e5b32a1 into googleapis:main Oct 31, 2025
33 of 36 checks passed
aakashanandg added a commit to aakashanandg/go-sql-spanner that referenced this pull request Oct 31, 2025
chore(ruby): Add native gem workflow for Ruby wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants