-
Notifications
You must be signed in to change notification settings - Fork 28
chore(ruby): Add native gem workflow for Ruby wrapper #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ruby): Add native gem workflow for Ruby wrapper #589
Conversation
79ff991 to
60272f8
Compare
| name: Build and Publish Native Gem | ||
|
|
||
| on: | ||
| release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should remove this trigger for now. We don't want to trigger this workflow when a release of database/sql is created, and that is what would happen here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.21' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a relatively old version of Go. Is that intentional? Otherwise, it should probably be updated to 1.25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
| @@ -1,44 +1,82 @@ | |||
| # Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed accidently. Reverting this change.
b885bb7 to
e2a1d71
Compare
e2a1d71 to
fa5c926
Compare
chore(ruby): Add native gem workflow for Ruby wrapper
chore(ruby): Add native gem workflow for Ruby wrapper