fix: backslash at end of string was misinterpreted

[olavloite]

A SQL string with a string literal that ended with an escaped backslash was misinterpreted by the statement parser as an unclosed literal. E.g. the string 'test\\' would be seen as an invalid literal.

[gemini-code-assist]

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a parsing bug where SQL string literals terminating with an escaped backslash were erroneously flagged as unclosed. The change modifies the statement parser to correctly interpret these sequences, ensuring robust handling of string literals in SQL queries. This improves the reliability of the SQL parser, preventing false-positive errors for valid SQL constructs.

Highlights

• SQL String Parsing Fix: Corrected an issue in the skipQuoted function where SQL string literals ending with an escaped backslash (e.g., 'test\') were incorrectly identified as unclosed literals. The parser now correctly recognizes \\ as an escaped backslash, preventing misinterpretation.
• Enhanced Test Coverage: Added new test cases to parser/statement_parser_test.go to validate the fix for escaped backslashes at the end of string literals, ensuring proper parsing across different SQL dialects and within various parsing contexts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where a string literal ending with an escaped backslash was misinterpreted by the statement parser. The change in statement_parser.go to also check for an escaped backslash (\\) in addition to an escaped quote is correct and addresses the issue. The added tests are comprehensive, covering both GoogleSQL and PostgreSQL dialects. I've found a minor issue in one of the new tests, where it's not correctly testing the scenario with comments. Other than that, the changes look good.

[bhatt4982]

LGTM...