Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenTelemetry tracing capabilities within the BigQuery client library by introducing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances BigQuery RPC tracing by introducing a new url.domain telemetry attribute. The HttpBigQueryRpc class now captures the domain from the resolved API host and attaches it to OpenTelemetry spans. The changes include adding a urlDomain field, initializing it in the constructor, and updating the BigQueryTelemetryTracer to define and use this new attribute. Unit tests have been added to verify the url.domain attribute for both default and custom host configurations. A review comment points out a potential issue where GenericUrl.getHost() could return null if the host lacks a scheme, leading to the silent omission of the url.domain attribute, suggesting improved validation or the use of java.net.URI for robustness.
This adds the url.domain attribute to http span tracing. This field should matching the proto domain if not overridden by user, otherwise it should match the user set value.
default domain
user set example