fix(bqjdbc): Log exception messages - part 2#12907
Merged
Conversation
Neenu1995
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances error logging across the BigQuery JDBC driver by ensuring exceptions are logged with their stack traces before being thrown. The changes refactor exception handling in various classes to capture and log exception details more effectively. Feedback identifies opportunities to improve the sequence of state checks in BigQueryBaseResultSet and to eliminate redundant string formatting in BigQueryJdbcProxyUtility and BigQueryJdbcUrlUtility by using the exception's message directly in the logging calls.
keshavdandeva
approved these changes
Apr 24, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Apr 24, 2026
**Fully Updated** The following files received end-to-end instrumentation (including direct throw upgrades): - BigQueryJdbcCustomLogger.java - BigQueryJdbcRootLogger.java - BigQueryBaseArray.java - BigQueryBaseStruct.java - BigQueryParameterHandler.java - BigQueryDriver.java - DataSource.java - BigQueryJdbcUrlUtility.java - BigQueryJdbcProxyUtility.java - BigQueryDaemonPollingTask.java - BigQueryDatabaseMetaData.java - BigQueryPreparedStatement.java - BigQueryBaseResultSet.java **Partially Updated** The following files received instrumentation only across catch boundaries (direct raw throws remain untouched): - BigQueryConnection.java - BigQueryStatement.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/505826451
Fully Updated
The following files received end-to-end instrumentation (including direct throw upgrades):
Partially Updated
The following files received instrumentation only across catch boundaries (direct raw throws remain untouched):