Skip to content

ci: add conditional-required-check for hermetic-build-scripts ci #12884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 10 commits into from
Apr 22, 2026
Merged

ci: add conditional-required-check for hermetic-build-scripts ci #12884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4ed642
ci: add conditional-required-check for hermetic-build-scripts ci
chingor13 Apr 21, 2026
4b10a4a
ci: add conditional-required-check for split units
chingor13 Apr 21, 2026
3458af0
ci: add conditional-required-check for auth units
chingor13 Apr 21, 2026
f062f6b
ci: add conditional-required-check for spanner-jdbc units
chingor13 Apr 21, 2026
ecec797
ci: add conditional-required-check for storage-nio units
chingor13 Apr 21, 2026
37f8889
ci: add conditional-required-check for sdk-platform-java downstream t…
chingor13 Apr 21, 2026
665b0e9
ci: add at least 1 job for split units confitional-required-check
chingor13 Apr 21, 2026
400081c
ci: add conditional-required-check for shared-dependencies downstream…
chingor13 Apr 21, 2026
fda797b
trigger auth tests when workflow touched
chingor13 Apr 22, 2026
4d875ff
fix logic when split units is empty
chingor13 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 11 additions & 27 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,17 @@ jobs:
JOB_TYPE: test
JOB_NAME: units-8-runtime-${{matrix.java}}
working-directory: ${{matrix.package}}
required:
needs: [ changes, split-units ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ needs.changes.outputs.packages != '[]' && contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
windows:
runs-on: windows-latest
steps:
Expand Down Expand Up @@ -332,30 +343,3 @@ jobs:
env:
library_generation_image_tag: 2.68.0
workspace_name: /workspace

# TODO: Uncomment the needed Github Actions
# dependencies:
# runs-on: ubuntu-latest
# strategy:
# matrix:
# java: [8, 11, 17]
# steps:
# - uses: actions/checkout@v3
# - uses: actions/setup-java@v3
# with:
# distribution: zulu
# java-version: ${{matrix.java}}
# - run: java -version
# - run: .kokoro/dependencies.sh
# clirr:
# runs-on: ubuntu-latest
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see clirr check enabled in this repo, can we reenable it? We used to have it in sdk-platform-java.

Copy link
Copy Markdown
Contributor Author

@chingor13 chingor13 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack: tracking in #12893

# steps:
# - uses: actions/checkout@v3
# - uses: actions/setup-java@v3
# with:
# distribution: zulu
# java-version: 8
# - run: java -version
# - run: .kokoro/build.sh
# env:
# JOB_TYPE: clirr
12 changes: 12 additions & 0 deletions .github/workflows/google-auth-library-java-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
filters: |
library:
- 'google-auth-library-java/**'
- '.github/workflows/google-auth-library-java-ci.yaml'
units-logging:
needs: filter
if: ${{ needs.filter.outputs.library == 'true' }}
Expand All @@ -54,3 +55,14 @@ jobs:
BUILD_SUBDIR: google-auth-library-java
JOB_TYPE: test
SUREFIRE_JVM_OPT: "-P '!slf4j2x,slf4j2x-test'"
required:
needs: [ units-logging ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
11 changes: 11 additions & 0 deletions .github/workflows/hermetic-build-scripts-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,14 @@ jobs:
# exclude generated golden files
# exclude owlbot until further refaction
black --check hermetic_build --exclude "(library_generation/tests/resources/goldens)"
required:
needs: [ library-generation-unit-tests, library-generation-lint-shell, library-generation-lint-python ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
12 changes: 12 additions & 0 deletions .github/workflows/java-spanner-jdbc-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
filters: |
library:
- 'java-spanner-jdbc/**'
- '.github/workflows/java-spanner-jdbc-ci.yaml'
units:
needs: filter
if: ${{ needs.filter.outputs.library == 'true' }}
Expand Down Expand Up @@ -141,3 +142,14 @@ jobs:
JOB_TYPE: lint
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
required:
needs: [ units, units-java8, windows, dependencies, javadoc, lint ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
12 changes: 12 additions & 0 deletions .github/workflows/java-storage-nio-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
filters: |
library:
- 'java-storage-nio/**'
- '.github/workflows/java-storage-nio-ci.yaml'
units:
needs: filter
if: ${{ needs.filter.outputs.library == 'true' }}
Expand Down Expand Up @@ -141,3 +142,14 @@ jobs:
JOB_TYPE: lint
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
required:
needs: [ units, units-java8, windows, dependencies, javadoc, lint ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
12 changes: 12 additions & 0 deletions .github/workflows/sdk-platform-java-downstream.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
library:
- 'sdk-platform-java/**'
- .kokoro/downstream-compatibility.sh
- .github/workflows/sdk-platform-java-downstream.yaml
downstream-compatibility:
needs: filter
if: ${{ needs.filter.outputs.library == 'true' }}
Expand Down Expand Up @@ -71,3 +72,14 @@ jobs:
sudo apt-get -y install libxml2-utils
- name: Perform downstream compatibility testing
run: .kokoro/downstream-compatibility-spring.sh
required:
needs: [ downstream-compatibility, downstream-compatibility-spring-generator ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
17 changes: 13 additions & 4 deletions .github/workflows/sdk-platform-java-downstream_unmanaged_dependency_check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ on:
branches:
- main
pull_request:
paths:
- .github/workflows/sdk-platform-java-downstream_unmanaged_dependency_check.yaml
- sdk-platform-java/java-shared-dependencies/**

name: sdk-platform-java Downstream Unmanaged Dependency Check
env:
Expand All @@ -22,7 +19,8 @@ jobs:
with:
filters: |
library:
- 'sdk-platform-java/**'
- 'sdk-platform-java/java-shared-dependencies/**'
- '.github/workflows/sdk-platform-java-downstream_unmanaged_dependency_check.yaml'
validate:
needs: filter
if: ${{ needs.filter.outputs.library == 'true' }}
Expand Down Expand Up @@ -96,3 +94,14 @@ jobs:
exit 1
fi
echo "Unmanaged dependency check passed"
required:
needs: [ validate ]
name: conditional-required-check
if: ${{ always() }} # Always run even if any "needs" jobs fail
runs-on: ubuntu-22.04
steps:
- name: Fail if any previous failure
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
- name: Success otherwise
run: echo "Success!"
Loading