storage: delete versioned files#1147
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Mar 2, 2016
Merged
Conversation
Closed
callmehiphop
added a commit
that referenced
this pull request
Mar 2, 2016
storage: delete versioned files
| // } | ||
| callback(); | ||
| }); | ||
| bucket.delete(done); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
storage: delete versioned files
gcf-owl-bot bot
added a commit
that referenced
this pull request
Feb 19, 2026
Source-Link: googleapis/googleapis@d4b1726 Source-Link: googleapis/googleapis-gen@5adfeeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhZGZlZWI4MTdmMDg1ZTE2ZTg3NWQ0ZGUzODMyMTJhNGQ3ODE1MzQifQ==
sofisl
pushed a commit
that referenced
this pull request
Feb 19, 2026
…#1147) (#7272) * feat: Update Compute Engine v1 API to revision 20260106 (#1148) Source-Link: googleapis/googleapis@d1e59aa Source-Link: googleapis/googleapis-gen@1307b9d Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjEzMDdiOWQ0YWUzNzU4Y2RiNDg1N2ExNDY2ZTI3ZWRjZjFjZTk2OTIifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Update Compute Engine v1beta API to revision 20260106 (#1147) Source-Link: googleapis/googleapis@d4b1726 Source-Link: googleapis/googleapis-gen@5adfeeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhZGZlZWI4MTdmMDg1ZTE2ZTg3NWQ0ZGUzODMyMTJhNGQ3ODE1MzQifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968 (possibly)
I can't positively say all of the ghost buckets had versioning enabled... but if they did, the explanation for not being able to delete them is we didn't delete old versions of the files. That makes sense to me!
In the after hook for the Storage system tests, this will now get all versions of a file from each bucket, so they will be deleted.