feat(firestore): Added FieldValue.minimum() and FieldValue.maximum()#8151
Merged
MarkDuckworth merged 13 commits intomainfrom May 4, 2026
Merged
feat(firestore): Added FieldValue.minimum() and FieldValue.maximum()#8151MarkDuckworth merged 13 commits intomainfrom
MarkDuckworth merged 13 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces FieldValue.minimum() and FieldValue.maximum() to the Firestore SDK, enabling server-side numeric transformations. The implementation includes a refactor of numeric transform logic into a base NumericFieldTransform class along with comprehensive unit, system, and type tests. Feedback highlights an opportunity to further reduce code duplication by moving shared methods to the base class and identifies a logic error in the isEqual() implementation regarding NaN values, which should be addressed and verified with additional test cases.
MarkDuckworth
changed the title
MarkDuckworth
changed the title
…numeric field values
product-auto-label
Bot
added
the
api: firestore
dlarocque
reviewed
May 4, 2026
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
MarkDuckworth
commented
May 4, 2026
dlarocque
approved these changes
May 4, 2026
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
MarkDuckworth
commented
May 4, 2026
MarkDuckworth
commented
May 4, 2026
Co-authored-by: Mark Duckworth <1124037+MarkDuckworth@users.noreply.github.com>
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
May 5, 2026
…oogleapis#8151) Co-authored-by: Brett Willis <brettjohnwillis@gmail.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel La Rocque <dlarocque@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally opened as a community contribution in googleapis/nodejs-firestore#2024. The original author @brettwillis has been preserved on the commits and as a co-author in the squash commit.
go/firestore-api-fieldvalue-take-minmax