Skip to content

fix(deps): bump google-api-core to 2.25.0#17599

Merged
parthea merged 1 commit into
mainfrom
bump-google-api-core
Jun 30, 2026
Merged

fix(deps): bump google-api-core to 2.25.0#17599
parthea merged 1 commit into
mainfrom
bump-google-api-core

Conversation

@parthea

@parthea parthea commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Bump the minimum version of google-api-core from 2.24.2 to 2.25.0 to avoid use of if hasattr(DEFAULT_CLIENT_INFO, "protobuf_runtime_version"): in generated code

@parthea parthea changed the title fix(deps): bump google-api-core fix(deps): bump google-api-core to 2.25.0 Jun 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum dependency version of google-api-core[grpc] from 2.24.2 to 2.25.0 across various configuration and setup files. Consequently, the conditional check verifying the presence of the protobuf_runtime_version attribute on DEFAULT_CLIENT_INFO has been removed, allowing the attribute to be set unconditionally in the generated client and transport files. There are no review comments, and I have no feedback to provide.

@parthea parthea force-pushed the bump-google-api-core branch from 03e3e08 to 62b5572 Compare June 30, 2026 15:09
@parthea parthea marked this pull request as ready for review June 30, 2026 15:29
@parthea parthea requested a review from a team as a code owner June 30, 2026 15:29
@parthea parthea merged commit 8b359e2 into main Jun 30, 2026
96 checks passed
@parthea parthea deleted the bump-google-api-core branch June 30, 2026 15:53
This was referenced Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants