chore: remove deprecated method #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=========================================
Coverage 76.24% 76.24%
Complexity 571 571
=========================================
Files 42 42
Lines 3334 3334
Branches 232 232
=========================================
Hits 2542 2542
Misses 647 647
Partials 145 145Continue to review full report at Codecov.
|
elharo
reviewed
Jan 18, 2020
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Not sure whether the test failure is related, but even if it isn't we should probably fix it before proceeding:
org.junit.ComparisonFailure: expected:<[NOT_FOUND]> but was:<[io.grpc.StatusRuntimeException: NOT_FOUND: Sink test-update-non-existing-sink-4e7474a2-c150-4968-9825-a54d33c14498 does not exist]>
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
elharo
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.