Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api client headers to outbound requests #182

Merged
merged 8 commits into from
Aug 6, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jul 31, 2020

Tested and verified that the headers are being set now on outbound requests

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #182 into master will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #182      +/-   ##
============================================
- Coverage     64.02%   63.71%   -0.32%     
  Complexity      650      650              
============================================
  Files           133      133              
  Lines          3886     3905      +19     
  Branches        198      199       +1     
============================================
  Hits           2488     2488              
- Misses         1287     1306      +19     
  Partials        111      111              
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/pubsublite/Stubs.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78e46c...e5a38b3. Read the comment docs.

@anguillanneuf anguillanneuf requested a review from a team July 31, 2020 21:21
@anguillanneuf anguillanneuf removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannahrogers-google Cc'ed you on an email thread. Sorry the requirements are a little different now. Could we remove gapic/ and add library version via gccl/{version}?

CC: @dazuma

@anguillanneuf anguillanneuf removed the request for review from a team August 3, 2020 23:30
@anguillanneuf anguillanneuf merged commit 0b47e06 into googleapis:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants