feat: add api client headers to outbound requests #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hannahrogers-google
added
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
============================================
- Coverage 64.02% 63.71% -0.32%
Complexity 650 650
============================================
Files 133 133
Lines 3886 3905 +19
Branches 198 199 +1
============================================
Hits 2488 2488
- Misses 1287 1306 +19
Partials 111 111
Continue to review full report at Codecov.
|
anguillanneuf
removed
the
kokoro:force-run
anguillanneuf
suggested changes
Aug 3, 2020
Contributor
There was a problem hiding this comment.
@hannahrogers-google Cc'ed you on an email thread. Sorry the requirements are a little different now. Could we remove gapic/ and add library version via gccl/{version}?
CC: @dazuma
anguillanneuf
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and verified that the headers are being set now on outbound requests