Skip to content

Conversation

@palmere-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner September 24, 2020 14:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2020
@palmere-google palmere-google removed the request for review from a team September 24, 2020 14:56
@palmere-google palmere-google changed the title feat: Move settings for the topic backlog reader to TopicBacklogReaderSettings fix: Move settings for the topic backlog reader to TopicBacklogReaderSettings Sep 24, 2020
@dpcollins-google dpcollins-google merged commit 0ee60eb into master Sep 24, 2020
@dpcollins-google dpcollins-google deleted the beam_example branch September 24, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants