Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Kafka{Producer/Consumer} to fix the number of partitions #322

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

dpcollins-google
Copy link
Collaborator

…instead of looking it up.

This prevents making too many queries to the number of partitions.

…instead of looking it up.

This prevents making too many queries to the number of partitions.
@dpcollins-google dpcollins-google requested a review from a team as a code owner October 22, 2020 15:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #322 into master will increase coverage by 0.04%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
+ Coverage     71.36%   71.41%   +0.04%     
+ Complexity      875      874       -1     
============================================
  Files           153      153              
  Lines          4722     4712      -10     
  Branches        227      228       +1     
============================================
- Hits           3370     3365       -5     
+ Misses         1225     1220       -5     
  Partials        127      127              
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsublite/kafka/ConsumerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...oogle/cloud/pubsublite/kafka/ProducerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...gle/cloud/pubsublite/kafka/PubsubLiteProducer.java 79.36% <66.66%> (+1.42%) 16.00 <1.00> (ø)
...gle/cloud/pubsublite/kafka/PubsubLiteConsumer.java 72.14% <75.00%> (+1.29%) 53.00 <1.00> (ø)
.../google/cloud/pubsublite/kafka/SharedBehavior.java 77.77% <100.00%> (-4.05%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cf834...7c3f124. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 23, 2020
@dpcollins-google dpcollins-google merged commit 3f27c86 into master Oct 23, 2020
@dpcollins-google dpcollins-google deleted the kafka-less-lookups branch October 23, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants