This repository was archived by the owner on Sep 19, 2023. It is now read-only.
buid(ci): add check to verify the BOM works in client libraries #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
chingor13
suggested changes
Oct 16, 2020
.kokoro/client-library-check.sh
Outdated
Comment on lines
52
to
78
| # java-bigquery | ||
| git clone https://github.com/googleapis/java-bigquery.git | ||
| cd java-bigquery | ||
| mvn install | ||
| cd google-cloud-bigquery | ||
| mvn validate -D${VERSION_KEY}=${VERSION} | ||
|
|
||
| # java-bigqueryconnection | ||
| git clone https://github.com/googleapis/java-bigqueryconnection.git | ||
| cd java-bigqueryconnection | ||
| mvn install | ||
| cd google-cloud-bigqueryconnection | ||
| mvn validate -D${VERSION_KEY}=${VERSION} | ||
|
|
||
| # java-storage | ||
| git clone https://github.com/googleapis/java-storage.git | ||
| cd java-storage | ||
| mvn install | ||
| cd google-cloud-storage | ||
| mvn validate -D${VERSION_KEY}=${VERSION} | ||
|
|
||
| # java-spanner | ||
| git clone https://github.com/googleapis/java-spanner.git | ||
| cd java-spanner | ||
| mvn install | ||
| cd google-cloud-spanner | ||
| mvn validate -D${VERSION_KEY}=${VERSION} No newline at end of file |
There was a problem hiding this comment.
Let's parameterize this script and run it in parallel (on actions?).
| cd java-bigqueryconnection | ||
| mvn install | ||
| cd google-cloud-bigqueryconnection | ||
| mvn validate -D${VERSION_KEY}=${VERSION} |
There was a problem hiding this comment.
Do we need to run all the tests? or just run the dependencies tests?
Co-authored-by: Jeff Ching <chingor@google.com>
|
implemented in #183 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177