-
Notifications
You must be signed in to change notification settings - Fork 136
test: clean up system-test setup against emulator #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use Docker image instead of manually downloading the emulator binary and running it.
059ecb5 to
5a13452
Compare
|
EDIT: This seems to be caused by a race condition where the The timeout in the integration tests against the emulator is caused by an eternal aborted-retry loop in
It seems that the above happens when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That really cleans it up a lot :-)
The test failure is not really related to this change, although it could be that the latest version of the emulator is behaving slightly differently from the previous version.
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/53010
Use Docker image instead of manually downloading the emulator binary and running it.