chore: Use AltContext to check DirectPath Used attribute #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
surbhigarg92
force-pushed
the
directpath_used_attr
branch
from
5c2f96c to
4f0779f
Compare
surbhigarg92
added
the
do not merge
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java
Outdated
Show resolved
Hide resolved
surbhigarg92
force-pushed
the
directpath_used_attr
branch
from
4f0779f to
ea3d27b
Compare
Contributor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for detecting DirectPath usage. Instead of checking the remote IP address, it now uses AltsContextUtil.check(), which inspects the ALTS context of the RPC. This is a good improvement as it's more robust and less brittle than relying on specific IP address prefixes. The changes are clean, and the removal of the now-unused isDirectPathUsed method and its related imports simplifies the code. Overall, this is a solid enhancement.
sakthivelmanii
approved these changes
Nov 17, 2025
surbhigarg92
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic to check if RPC has used DirectPath or not. Noe Alts Information will be used to check if DP is used instead of relying on IP address range