fix: allow DML THEN RETURN with retryAbortsInternally=false #4225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
olavloite
previously approved these changes
Nov 14, 2025
olavloite
force-pushed
the
issue-4197
branch
from
d2ec78f to
f4f82fe
Compare
olavloite
approved these changes
Nov 14, 2025
|
|
||
| @Test | ||
| public void testTransactionTimeoutInAutoCommit() {} | ||
| public void testCanUseAllMethodsWithInternalRetriesDisabled() { |
There was a problem hiding this comment.
Can we add a test for failure scenario as well. How the errors will be propagated to end users if the query fails and retries are disabled.
aakashanandg
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4197