chore: add ObjectLockMode [de]serializers to XmlObjectParser for sake of completeness #3382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
| ImmutableList.of(new StringEnumValueSerializer<>(StorageClass.class)))); | ||
| ImmutableList.of( | ||
| new StringEnumValueSerializer<>(StorageClass.class), | ||
| new StringEnumValueSerializer<>(ObjectLockMode.class)))); |
Contributor
There was a problem hiding this comment.
Is something similar required for PredefinedAcl?
Collaborator
Author
There was a problem hiding this comment.
PredefinedAcl is a java enum, not a StringEnumValue, for that we would need to add both a new serializer and deserializer, which would be more appropriate for a separate PR.
ShreyasSinha
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value provided in CreateMultipartUploadRequest is set to the
x-goog-object-lock-modeheader, this change simply ensures that if the request is serialized/deserialized using our mapper it will work as expected.