Skip to content

Conversation

@craig08
Copy link
Contributor

@craig08 craig08 commented Feb 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #25 🦕

@product-auto-label product-auto-label bot added the api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API. label Feb 16, 2024
@craig08 craig08 marked this pull request as ready for review February 16, 2024 17:58
@craig08 craig08 requested a review from a team as a code owner February 16, 2024 17:58
@craig08 craig08 requested a review from PingXie February 16, 2024 17:58
@craig08 craig08 force-pushed the notebook branch 2 times, most recently from b08c061 to 8d944a9 Compare February 16, 2024 18:25
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@PingXie PingXie merged commit 5e09c19 into googleapis:main Feb 16, 2024
@craig08 craig08 deleted the notebook branch February 16, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create notebooks for the integrations

3 participants