Skip to content

Conversation

@PingXie
Copy link
Contributor

@PingXie PingXie commented Feb 19, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

- Introduce initial ipynb file as a scaffold for demonstrating the integration of LangChain with Memorystore for Redis.
- The notebook is currently a placeholder, with detailed examples and guidance to be added.
@PingXie PingXie requested a review from a team as a code owner February 19, 2024 04:36
@product-auto-label product-auto-label bot added the api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API. label Feb 19, 2024
PingXie and others added 4 commits February 23, 2024 08:37
Co-authored-by: Tabby <tabby.lewis9@gmail.com>
Co-authored-by: Tabby <tabby.lewis9@gmail.com>
Co-authored-by: Tabby <tabby.lewis9@gmail.com>
Co-authored-by: Tabby <tabby.lewis9@gmail.com>
@averikitsch averikitsch self-requested a review February 23, 2024 18:23
@PingXie PingXie requested review from craig08 and tabbyl21 February 24, 2024 20:31
@PingXie
Copy link
Contributor Author

PingXie commented Feb 24, 2024

@averikitsch @tabbyl21

This is all working and aligned with the pg sample (with some adjustments, mostly to accommodate the private endpoint constraints). Ready for your review.

PingXie and others added 2 commits February 27, 2024 13:56
Co-authored-by: Tabby <tabathal@google.com>
Co-authored-by: Tabby <tabathal@google.com>
@PingXie PingXie merged commit a1cd9e0 into main Feb 27, 2024
@PingXie PingXie deleted the quick-start branch February 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants