Skip to content

Conversation

@PingXie
Copy link
Contributor

@PingXie PingXie commented Feb 23, 2024

  • Fixed inclusion of HNSW parameters (M, EF_CONSTRUCTION, EF_RUNTIME) in Redis index creation.
  • Corrected test assertions to accurately reflect expected key count in Redis.
  • Updated check_index_exists to properly validate HNSW index configurations.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

- Fixed inclusion of HNSW parameters (M, EF_CONSTRUCTION, EF_RUNTIME) in Redis index creation.
- Corrected test assertions to accurately reflect expected key count in Redis.
- Updated check_index_exists to properly validate HNSW index configurations.
@PingXie PingXie requested a review from a team as a code owner February 23, 2024 05:07
@PingXie PingXie requested a review from craig08 February 23, 2024 05:07
@product-auto-label product-auto-label bot added the api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API. label Feb 23, 2024
@averikitsch averikitsch merged commit f011df1 into main Feb 23, 2024
@averikitsch averikitsch deleted the bugfix branch February 23, 2024 17:10
@PingXie PingXie restored the bugfix branch March 6, 2024 04:55
@averikitsch averikitsch deleted the bugfix branch July 16, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants