fix(sidekick): Map field attribute in discovery (#2414)

Author: coryan

internal/sidekick/internal/parser/discovery/map_field.go

@@ -51,6 +51,7 @@ func maybeMapOfObjectField(model *api.API, message *api.Message, input *property
 		Typez:         api.MESSAGE_TYPE,
 		TypezID:       typezID,
 		Deprecated:    input.Schema.Deprecated,
+		Map:           true,
 	}
 	return field
 }
@@ -72,6 +73,7 @@ func maybeMapOfEnumField(model *api.API, message *api.Message, input *property)
 		Typez:         api.MESSAGE_TYPE,
 		TypezID:       typezID,
 		Deprecated:    input.Schema.Deprecated,
+		Map:           true,
 	}
 	return field, nil
 }
@@ -90,6 +92,7 @@ func maybeMapOfPrimitiveField(model *api.API, message *api.Message, input *prope
 		Typez:         api.MESSAGE_TYPE,
 		TypezID:       typezID,
 		Deprecated:    input.Schema.Deprecated,
+		Map:           true,
 	}
 	return field, nil
 }

internal/sidekick/internal/parser/discovery/map_field_test.go

@@ -19,6 +19,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/googleapis/librarian/internal/sidekick/internal/api"
 	"github.com/googleapis/librarian/internal/sidekick/internal/api/apitest"
 )
@@ -57,6 +58,7 @@ func TestMapFields(t *testing.T) {
 				Deprecated:    true,
 				Typez:         api.MESSAGE_TYPE,
 				TypezID:       "$map<string, string>",
+				Map:           true,
 			},
 		},
 	}
@@ -125,6 +127,7 @@ func TestMapFieldWithObjectValues(t *testing.T) {
 				Deprecated:    true,
 				Typez:         api.MESSAGE_TYPE,
 				TypezID:       "$map<string, .package.SomeOtherMessage>",
+				Map:           true,
 			},
 		},
 	}
@@ -200,6 +203,7 @@ func TestMapFieldWithEnumValues(t *testing.T) {
 				Deprecated:    true,
 				Typez:         api.MESSAGE_TYPE,
 				TypezID:       "$map<string, .package.Message.enumMapField>",
+				Map:           true,
 			},
 		},
 	}
@@ -290,9 +294,9 @@ func TestMapScalarTypes(t *testing.T) {
 		input := &schema{
 			Properties: []*property{
 				{
-					Name: "enumMapField",
+					Name: "mapField",
 					Schema: &schema{
-						Description: "The description for enumMapField.",
+						Description: "The description for mapField.",
 						Type:        "object",
 						AdditionalProperties: &schema{
 							Type:   test.Type,
@@ -307,8 +311,18 @@ func TestMapScalarTypes(t *testing.T) {
 			t.Error(err)
 			continue
 		}
-		if len(message.Fields) != 1 {
-			t.Errorf("expected exactly one field, got=%v", message.Fields)
+		wantFields := []*api.Field{
+			{
+				Name:          "mapField",
+				JSONName:      "mapField",
+				ID:            ".package.Message.mapField",
+				Documentation: "The description for mapField.",
+				Typez:         api.MESSAGE_TYPE,
+				Map:           true,
+			},
+		}
+		if diff := cmp.Diff(wantFields, message.Fields, cmpopts.IgnoreFields(api.Field{}, "TypezID")); diff != "" {
+			t.Errorf("mismatch (-want, +got):\n%s", diff)
 			continue
 		}
 		mapMessage, ok := model.State.MessageByID[message.Fields[0].TypezID]