-
Notifications
You must be signed in to change notification settings - Fork 108
docs: adds OR sample #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
docs: adds OR sample #1092
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e7353a4
docs: adds OR sample
telpirion c2e3452
Merge branch 'main' into or-sample
telpirion 84f02b8
fixed tests
telpirion 11e87b6
per linter
telpirion 58ce187
exclude IDE stuff
telpirion 4fd5523
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 659d935
remove unneeded stuff
telpirion c45b3a5
git is hard
telpirion 24e0777
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 40e541f
Merge branch 'or-sample' of https://github.com/googleapis/nodejs-data…
gcf-owl-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ system-test/*key.json | |
| .DS_Store | ||
| package-lock.json | ||
| __pycache__ | ||
| .vscode | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // sample-metadata: | ||
| // title: Create a union between two filters | ||
| // description: Create a union between two filters (logical OR operator) | ||
|
|
||
| async function main() { | ||
| // [START datastore_query_filter_or] | ||
| /** | ||
| * TODO(developer): Uncomment these variables before running the sample. | ||
| */ | ||
| // const projectId = "your Google Cloud project id"; | ||
|
|
||
| // Imports the Cloud Datastore | ||
| const {Datastore, PropertyFilter, or} = require('@google-cloud/datastore'); | ||
|
|
||
| async function queryFilterOr() { | ||
| // Instantiate the Datastore | ||
| const datastore = new Datastore(); | ||
| const query = datastore | ||
| .createQuery('Task') | ||
| .filter( | ||
| or([ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Look good! |
||
| new PropertyFilter('description', '=', 'Buy milk'), | ||
| new PropertyFilter('description', '=', 'Feed cats'), | ||
| ]) | ||
| ); | ||
|
|
||
| const [entities] = await datastore.runQuery(query); | ||
| for (const entity of entities) { | ||
| console.log(`Entity found: ${entity['description']}`); | ||
| } | ||
| } | ||
|
|
||
| await queryFilterOr(); | ||
| // [END datastore_query_filter_or] | ||
| } | ||
|
|
||
| exports.queryFilterOr = main; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| /* eslint-disable */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const path = require('path'); | ||
| const {assert} = require('chai'); | ||
| const {describe, it, after, before} = require('mocha'); | ||
| const sinon = require('sinon'); | ||
| const {Datastore} = require('@google-cloud/datastore'); | ||
| const datastore = new Datastore(); | ||
|
|
||
| const {queryFilterOr} = require('../queryFilterOr'); | ||
| let taskKey1, taskKey2; | ||
|
|
||
| describe('Creating a union query', () => { | ||
| const stubConsole = function () { | ||
| sinon.stub(console, 'error'); | ||
| sinon.stub(console, 'log'); | ||
| }; | ||
|
|
||
| const restoreConsole = function () { | ||
| console.log.restore(); | ||
| console.error.restore(); | ||
| }; | ||
|
|
||
| beforeEach(stubConsole); | ||
| afterEach(restoreConsole); | ||
|
|
||
| before(async () => { | ||
| taskKey1 = datastore.key('Task'); | ||
| const entity1 = { | ||
| key: taskKey1, | ||
| data: { | ||
| description: 'Buy milk', | ||
| }, | ||
| }; | ||
|
|
||
| taskKey2 = datastore.key('Task'); | ||
| const entity2 = { | ||
| key: taskKey2, | ||
| data: { | ||
| description: 'Feed cats', | ||
| }, | ||
| }; | ||
|
|
||
| await datastore.upsert(entity1); | ||
| await datastore.upsert(entity2); | ||
| }); | ||
|
|
||
| after(async () => { | ||
| await datastore.delete(taskKey1); | ||
| await datastore.delete(taskKey2); | ||
| }); | ||
|
|
||
| it('should get a combination of items from the Datastore', async () => { | ||
| await queryFilterOr(); | ||
| assert.include(console.log.firstCall.args[0], 'Entity'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Now these functions are directly available to the user.