Skip to content

Conversation

@odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Jan 7, 2025

This change brings in the bases for x-goog-spanner-request-id by commit AtomicCounter and the various utilities plus some unit tests.

Ripped out of PR #2205
Updates #2200

@odeke-em odeke-em requested review from a team as code owners January 7, 2025 08:49
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jan 7, 2025
@odeke-em
Copy link
Contributor Author

odeke-em commented Jan 7, 2025

Kindly pinging @olavloite @surbhigarg92 to help bring this in as it is carved out of the larger PR #2205 and is isolated away from main code.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-bases branch 3 times, most recently from e82d493 to 60204be Compare January 24, 2025 03:36
@odeke-em odeke-em requested a review from olavloite January 24, 2025 03:39
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-bases branch from 366e635 to 77ff03e Compare February 6, 2025 17:58
@odeke-em odeke-em requested a review from a team as a code owner February 6, 2025 17:58
@odeke-em
Copy link
Contributor Author

odeke-em commented Feb 6, 2025

@surbhigarg92 @alkatrivedi @sakthivelmanii @harshachinta kindly help me trigger the bot runs.

This change brings in the bases for x-goog-spanner-request-id
by commit AtomicCounter and the various utilities plus some
unit tests.

Ripped out of PR googleapis#2205
Updates  googleapis#2200
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-bases branch from 77ff03e to b277b36 Compare February 8, 2025 12:55
@odeke-em
Copy link
Contributor Author

odeke-em commented Feb 8, 2025

Kind ping @surbhigarg92 @olavloite

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2025
@olavloite olavloite added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2025
@olavloite olavloite merged commit 0008038 into googleapis:main Feb 9, 2025
15 of 18 checks passed
@odeke-em odeke-em deleted the x-goog-spanner-request-id-bases branch February 9, 2025 11:15
@odeke-em
Copy link
Contributor Author

odeke-em commented Feb 9, 2025

Awesome and thank you @olavloite 🤘🏾👏🏿👏🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants