Skip to content

Conversation

@alexander-fenster
Copy link
Contributor

Uses JSON proto load instead of GoogleProtoFilesRoot to load a proto for RetryInfo. Also, updates the JSON proto to include google/rpc/error_details.proto.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@alexander-fenster alexander-fenster requested a review from a team September 13, 2019 22:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #690 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files          12       12              
  Lines        1350     1349       -1     
  Branches      213      213              
==========================================
- Hits         1337     1336       -1     
  Misses          4        4              
  Partials        9        9
Impacted Files Coverage Δ
src/transaction-runner.ts 98.73% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc46dc...8044ed6. Read the comment docs.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2019
@alexander-fenster alexander-fenster merged commit 279fc97 into master Sep 14, 2019
@alexander-fenster alexander-fenster deleted the use-json-proto branch September 14, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants