Skip to content

fix: adjust timeout durations #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix: adjust timeout durations #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v1/doc/google/iam/v1/doc_policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* {
* "bindings": [
* {
* "role": "role/resourcemanager.organizationAdmin",
* "role": "roles/resourcemanager.organizationAdmin",
* "members": [
* "user:mike@example.com",
* "group:admins@example.com",
Expand Down
17 changes: 11 additions & 6 deletions src/v1/spanner_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,17 +349,17 @@ class SpannerClient {
* The request object that will be sent.
* @param {string} request.database
* Required. The database in which the new sessions are created.
* @param {Object} [request.sessionTemplate]
* Parameters to be applied to each created session.
*
* This object should have the same structure as [Session]{@link google.spanner.v1.Session}
* @param {number} [request.sessionCount]
* @param {number} request.sessionCount
* Required. The number of sessions to be created in this batch call.
* The API may return fewer than the requested number of sessions. If a
* specific number of sessions are desired, the client can make additional
* calls to BatchCreateSessions (adjusting
* session_count
* as necessary).
* @param {Object} [request.sessionTemplate]
* Parameters to be applied to each created session.
*
* This object should have the same structure as [Session]{@link google.spanner.v1.Session}
* @param {Object} [options]
* Optional parameters. You can override the default settings for this call, e.g, timeout,
* retries, paginations, etc. See [gax.CallOptions]{@link https://googleapis.github.io/gax-nodejs/interfaces/CallOptions.html} for the details.
Expand All @@ -380,7 +380,12 @@ class SpannerClient {
* });
*
* const formattedDatabase = client.databasePath('[PROJECT]', '[INSTANCE]', '[DATABASE]');
* client.batchCreateSessions({database: formattedDatabase})
* const sessionCount = 0;
* const request = {
* database: formattedDatabase,
* sessionCount: sessionCount,
* };
* client.batchCreateSessions(request)
* .then(responses => {
* const response = responses[0];
* // doThingsWith(response)
Expand Down
12 changes: 6 additions & 6 deletions src/v1/spanner_client_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
"initial_retry_delay_millis": 250,
"retry_delay_multiplier": 1.3,
"max_retry_delay_millis": 32000,
"initial_rpc_timeout_millis": 60000,
"initial_rpc_timeout_millis": 360000,
"rpc_timeout_multiplier": 1.0,
"max_rpc_timeout_millis": 60000,
"total_timeout_millis": 600000
"max_rpc_timeout_millis": 360000,
"total_timeout_millis": 3600000
},
"streaming": {
"initial_retry_delay_millis": 250,
"retry_delay_multiplier": 1.3,
"max_retry_delay_millis": 32000,
"initial_rpc_timeout_millis": 120000,
"initial_rpc_timeout_millis": 360000,
"rpc_timeout_multiplier": 1.0,
"max_rpc_timeout_millis": 120000,
"total_timeout_millis": 1200000
"max_rpc_timeout_millis": 360000,
"total_timeout_millis": 3600000
},
"long_running": {
"initial_retry_delay_millis": 250,
Expand Down
10 changes: 5 additions & 5 deletions synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-09-20T11:24:28.610954Z",
"updateTime": "2019-09-27T11:27:44.182217Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.36.3",
"dockerImage": "googleapis/artman@sha256:66ca01f27ef7dc50fbfb7743b67028115a6a8acf43b2d82f9fc826de008adac4"
"version": "0.37.1",
"dockerImage": "googleapis/artman@sha256:6068f67900a3f0bdece596b97bda8fc70406ca0e137a941f4c81d3217c994a80"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "44e588d97e7497dff01107d39b6a19062f9a4ffa",
"internalRef": "270200097"
"sha": "cd112d8d255e0099df053643d4bd12c228ef7b1b",
"internalRef": "271468707"
}
},
{
Expand Down