Skip to content

chore: fix issue where unreferenced enums weren't getting generated into types #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

chore: fix issue where unreferenced enums weren't getting generated into types #6051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/unit/vertexai/genai/test_genai_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,4 @@ async def test_call_aclose_async_client(self):
project=_TEST_PROJECT, location=_TEST_LOCATION
).aio
await async_client.aclose()
mock_aclose.assert_called_once()
mock_aclose.assert_called()
6 changes: 0 additions & 6 deletions vertexai/_genai/types/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,9 +587,6 @@
from .common import OptimizeResponseEndpointDict
from .common import OptimizeResponseEndpointOrDict
from .common import OptimizeResponseOrDict
from .common import OptimizerMethodPlaceholder
from .common import OptimizerMethodPlaceholderDict
from .common import OptimizerMethodPlaceholderOrDict
from .common import OptimizeTarget
from .common import PairwiseChoice
from .common import PairwiseMetricInput
Expand Down Expand Up @@ -1746,9 +1743,6 @@
"PromptOptimizerConfig",
"PromptOptimizerConfigDict",
"PromptOptimizerConfigOrDict",
"OptimizerMethodPlaceholder",
"OptimizerMethodPlaceholderDict",
"OptimizerMethodPlaceholderOrDict",
"ApplicableGuideline",
"ApplicableGuidelineDict",
"ApplicableGuidelineOrDict",
Expand Down
20 changes: 0 additions & 20 deletions vertexai/_genai/types/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12081,26 +12081,6 @@ class PromptOptimizerConfigDict(TypedDict, total=False):
PromptOptimizerConfigOrDict = Union[PromptOptimizerConfig, PromptOptimizerConfigDict]


class OptimizerMethodPlaceholder(_common.BaseModel):
"""Placeholder class to generate OptimizerMethod enum in common.py."""

method: Optional[PromptOptimizerMethod] = Field(
default=None, description="""The method for optimizing multiple prompts."""
)


class OptimizerMethodPlaceholderDict(TypedDict, total=False):
"""Placeholder class to generate OptimizerMethod enum in common.py."""

method: Optional[PromptOptimizerMethod]
"""The method for optimizing multiple prompts."""


OptimizerMethodPlaceholderOrDict = Union[
OptimizerMethodPlaceholder, OptimizerMethodPlaceholderDict
]


class ApplicableGuideline(_common.BaseModel):
"""Applicable guideline for the optimize_prompt method."""

Expand Down
Loading