Skip to content

Conversation

@parthea
Copy link
Collaborator

@parthea parthea commented Nov 10, 2025

Additional clean up following #856

@parthea parthea requested review from a team as code owners November 10, 2025 12:04
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 10, 2025
ohmayr
ohmayr previously approved these changes Nov 11, 2025
@vchudnov-g
Copy link
Contributor

I am implementing similar fixes to additional tests. I will continue tomorrow.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 12, 2025
with pytest.warns(
DeprecationWarning,
match="argument is deprecated because of a potential security risk",
):
Copy link
Contributor

@daniel-sanche daniel-sanche Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could extract these lines, so it doesn't need to be copy/pasted in some many places?

I'm imagining something like:

assert_deprecation_warning = functools.partial(
    pytest.warns, 
    DeprecationWarning, 
    match="argument is deprecated because of a potential security risk"
)


with assert_deprecation_warning():
   ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Done.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 13, 2025
@vchudnov-g vchudnov-g merged commit 4f68f93 into main Nov 13, 2025
48 checks passed
@vchudnov-g vchudnov-g deleted the clean-up-owlbot branch November 13, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants