-
Notifications
You must be signed in to change notification settings - Fork 95
chore(librarian): clean up owlbot files and pin image sha #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am implementing similar fixes to additional tests. I will continue tomorrow. |
| with pytest.warns( | ||
| DeprecationWarning, | ||
| match="argument is deprecated because of a potential security risk", | ||
| ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could extract these lines, so it doesn't need to be copy/pasted in some many places?
I'm imagining something like:
assert_deprecation_warning = functools.partial(
pytest.warns,
DeprecationWarning,
match="argument is deprecated because of a potential security risk"
)
with assert_deprecation_warning():
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Done.
Additional clean up following #856