Skip to content

fix: Yield row count from read session if otherwise unknown #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

fix: Yield row count from read session if otherwise unknown #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigframes/session/read_api_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def process_page(page):
if peek:
batches = pyarrow_utils.truncate_pyarrow_iterable(batches, max_results=peek)

rows = node.source.n_rows
rows = node.source.n_rows or session.estimated_row_count
if peek and rows:
rows = min(peek, rows)

Expand Down
6 changes: 6 additions & 0 deletions tests/system/small/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,12 @@ def test_filter_df(scalars_dfs):
assert_pandas_df_equal(bf_result, pd_result)


def test_read_gbq_direct_to_batches_row_count(unordered_session):
df = unordered_session.read_gbq("bigquery-public-data.usa_names.usa_1910_2013")
iter = df.to_pandas_batches()
assert iter.total_rows == 5552452


def test_df_to_pandas_batches(scalars_dfs):
scalars_df, scalars_pandas_df = scalars_dfs

Expand Down