Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Nov 14, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. samples Issues that are directly related to samples. labels Nov 14, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 14, 2025
@tswast tswast marked this pull request as ready for review November 14, 2025 21:42
@tswast tswast requested review from a team as code owners November 14, 2025 21:42
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from gbq_connector.py for easier reuse.

Copy link
Collaborator Author

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comments as todos from offline feedback.

@shuoweil
Copy link

@tswast Could you please checked the failed tests for Kokoro?

@shuoweil shuoweil merged commit ac771c1 into main Nov 17, 2025
26 checks passed
@shuoweil shuoweil deleted the tswast-sample branch November 17, 2025 18:37
tswast added a commit that referenced this pull request Nov 17, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.6.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>pandas-gbq: 0.31.0</summary>

##
[0.31.0](v0.30.0...v0.31.0)
(2025-11-17)

### Features

* add pandas_gbq.sample (#983)
([ac771c1](ac771c12))

</details>

---------

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-pandas API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants