Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the unnest function lost needed type information #298

Merged
merged 17 commits into from Aug 26, 2021

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented Aug 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #297 馃

],
)
def test_unnest_function(args, kw):
import sqlalchemy_bigquery # noqa
Copy link
Contributor

@tseaver tseaver Aug 26, 2021

Is this import to get background registrations done?

Copy link
Contributor Author

@jimfulton jimfulton Aug 26, 2021

Yup. I'll add a comment to that effect.

Copy link
Contributor Author

@jimfulton jimfulton Aug 26, 2021

done

@jimfulton jimfulton merged commit 1233182 into googleapis:master Aug 26, 2021
9 checks passed
@jimfulton jimfulton deleted the fix-unnest-297 branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants