fix: Return Correct Column Order in get_multi_foreign_keys #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
reviewed
Oct 20, 2025
Ensure both referred and constrained columns reported by `get_multi_foreign_keys` are in the same order matching the constraint declaration. Uses information for the unique constraint corresponding to the foreign key constraint in order to ensure its columns are ordered correctly. Previously, the `CONSTRAINT_COLUMN` view in the information schema was used to retrieve the referred columns, and that view offers no information about column order. Instead, we use the KEY_COLUMN_USAGE view for the corresponding unique constraint, which is ordered. This requires consulting the `REFERENTIAL_CONSTRAINTS` view in order to find the unique constraint associated with the foreign key. Unfortunately, this view has a [bug in the emulator](GoogleCloudPlatform/cloud-spanner-emulator#279) related to cross-schema foreign keys. I had to skip a test for cross-schema foreign keys due to the emulator issue. I've confirmed a real spanner does not have this issue. fixes: googleapis#779
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure both referred and constrained columns reported by
get_multi_foreign_keysare in the same order matching the constraint declaration. Uses information for the unique constraint corresponding to the foreign key constraint in order to ensure its columns are ordered correctly.Previously, the
CONSTRAINT_COLUMNview in the information schema was used to retrieve the referred columns, and that view offers no information about column order. Instead, we use theKEY_COLUMN_USAGEview for the corresponding unique constraint, which is ordered.This requires consulting the
REFERENTIAL_CONSTRAINTSview in order to find the unique constraint associated with the foreign key. Unfortunately, this view has a bug in the emulator related to cross-schema foreign keys. I had to skip a test for cross-schema foreign keys due to the emulator issue. I've confirmed a real spanner does not have this issue.fixes: #779