Skip to content

Conversation

@olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 10, 2025

Columns that are assigned a PENDING_COMMIT_TIMESTAMP() value cannot be
included in THEN RETURN clauses.

Fixes this build error: https://github.com/googleapis/python-spanner-sqlalchemy/actions/runs/19180600096/job/54948361746?pr=798

A recent fix in the Emulator caused the samples for SQLAlchemy to start fail. That is not due to a bug in the Emulator, but due to a bug fix in the Emulator. Previously, the Emulator would allow something that would fail on Spanner. That difference has now been fixed.

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. samples Issues that are directly related to samples. labels Nov 10, 2025
Columns that are assigned a PENDING_COMMIT_TIMESTAMP() value cannot be
included in THEN RETURN clauses.
@olavloite olavloite force-pushed the run-samples-with-emulator-1.5.42 branch from 93a258d to c78f13c Compare November 10, 2025 10:04
@olavloite olavloite changed the title build: run samples with Emulator version 1.5.42 chore: exclude last_update from the THEN RETURN clause Nov 10, 2025
@olavloite olavloite requested a review from bhatt4982 November 10, 2025 10:11
Copy link
Contributor

@bhatt4982 bhatt4982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit 6cbf00b into main Nov 10, 2025
16 checks passed
@olavloite olavloite deleted the run-samples-with-emulator-1.5.42 branch November 10, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants