Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Nov 5, 2025

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 5, 2025
@ohmayr ohmayr marked this pull request as ready for review November 5, 2025 09:23
@ohmayr ohmayr requested review from a team as code owners November 5, 2025 09:23
@ohmayr ohmayr force-pushed the onboard-to-librarian branch from e75f0ce to ff09a8a Compare November 5, 2025 09:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Nov 5, 2025
@ohmayr ohmayr force-pushed the onboard-to-librarian branch from ff09a8a to 8d3c937 Compare November 5, 2025 09:39
@ohmayr ohmayr changed the title wip chore: onboard to librarian Nov 5, 2025
@ohmayr ohmayr force-pushed the onboard-to-librarian branch from a640ea4 to 7ad24b0 Compare November 5, 2025 18:41
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 5, 2025
@ohmayr ohmayr force-pushed the onboard-to-librarian branch from 7ad24b0 to 0932137 Compare November 5, 2025 19:52
rahul2393
rahul2393 previously approved these changes Nov 6, 2025
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per offline discussion, here is an updated remove_regex

@ohmayr ohmayr force-pushed the onboard-to-librarian branch from bec92fc to 0fb058e Compare November 11, 2025 22:51
@ohmayr ohmayr requested a review from a team as a code owner November 11, 2025 22:51
@ohmayr ohmayr requested a review from nicain November 11, 2025 22:51
rahul2393
rahul2393 previously approved these changes Nov 14, 2025
@rahul2393
Copy link
Contributor

@parthea @ohmayr Is this good to merge?

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you check if librarian release stage is working?

I encountered the following error

Traceback (most recent call last):
  File "/app/./cli.py", line 1497, in handle_release_stage
    _update_version_for_library(repo, output, path_to_library, version)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/./cli.py", line 1234, in _update_version_for_library
    updated_content = _process_version_file(
        _read_text_file(version_file), version, version_file
    )
  File "/app/./cli.py", line 1168, in _process_version_file
    raise ValueError(
        f"Could not find version string in {version_path}. File was not modified."
    )
ValueError: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/app/./cli.py", line 1592, in <module>
    args.func(librarian=args.librarian, repo=args.repo, output=args.output)
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/./cli.py", line 1509, in handle_release_stage
    raise ValueError(f"Release stage failed: {e}") from e
ValueError: Release stage failed: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.

@parthea
Copy link
Contributor

parthea commented Nov 18, 2025

I was able to run librarian release stage after making this change

partheniou@partheniou-vm-3:~/git/python-spanner$ git diff
diff --git a/google/cloud/spanner_dbapi/version.py b/google/cloud/spanner_dbapi/version.py
index 6fbb80eb..0ae3005c 100644
--- a/google/cloud/spanner_dbapi/version.py
+++ b/google/cloud/spanner_dbapi/version.py
@@ -13,8 +13,8 @@
 # limitations under the License.
 
 import platform
-from google.cloud.spanner_v1 import gapic_version as package_version
 
 PY_VERSION = platform.python_version()
-VERSION = package_version.__version__
+__version__ = "3.59.0"
+VERSION = __version__
 DEFAULT_USER_AGENT = "gl-dbapi/" + VERSION

@ohmayr ohmayr force-pushed the onboard-to-librarian branch from 5044f23 to 07165db Compare November 19, 2025 03:35
@parthea parthea merged commit 4bb4622 into main Nov 19, 2025
22 checks passed
@parthea parthea deleted the onboard-to-librarian branch November 19, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants