-
Notifications
You must be signed in to change notification settings - Fork 101
chore: onboard to librarian #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e75f0ce to
ff09a8a
Compare
ff09a8a to
8d3c937
Compare
a640ea4 to
7ad24b0
Compare
7ad24b0 to
0932137
Compare
0932137 to
bde609c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per offline discussion, here is an updated remove_regex
bec92fc to
0fb058e
Compare
9a56faf to
4b3bc2c
Compare
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you check if librarian release stage is working?
I encountered the following error
Traceback (most recent call last):
File "/app/./cli.py", line 1497, in handle_release_stage
_update_version_for_library(repo, output, path_to_library, version)
~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/./cli.py", line 1234, in _update_version_for_library
updated_content = _process_version_file(
_read_text_file(version_file), version, version_file
)
File "/app/./cli.py", line 1168, in _process_version_file
raise ValueError(
f"Could not find version string in {version_path}. File was not modified."
)
ValueError: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/./cli.py", line 1592, in <module>
args.func(librarian=args.librarian, repo=args.repo, output=args.output)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/./cli.py", line 1509, in handle_release_stage
raise ValueError(f"Release stage failed: {e}") from e
ValueError: Release stage failed: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.
|
I was able to run |
5044f23 to
07165db
Compare
Towards googleapis/librarian#2460