-
Notifications
You must be signed in to change notification settings - Fork 166
refactor(storage): deprecate Bucket.create() and requester_pays #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage): deprecate Bucket.create() and requester_pays #49
Conversation
|
Moved here from googleapis/google-cloud-python#9893 |
frankyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits but overall LGTM.
|
Systests failed with (same as in other PRs): |
|
Looks like they've already fixed it. #52 Merged master and tests are passing. |
frankyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…leapis#49) * refactor(storage): deprecate Bucket.create() and requester_pays * add_test_to_increase_cover * resolve conflicts * resolve conflicts * add new way of setting requester_pays into doclines Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
…leapis#49) * refactor(storage): deprecate Bucket.create() and requester_pays * add_test_to_increase_cover * resolve conflicts * resolve conflicts * add new way of setting requester_pays into doclines Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Towards #38