Skip to content

tests: move system tests into a package #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2020
Merged

tests: move system tests into a package #51

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33c2407
tests: move system tests into a package
tseaver Feb 11, 2020
423fa5f
Merge branch 'master' into tests-port-gcp-9777
tseaver Feb 12, 2020
8c5a03a
Merge branch 'master' into tests-port-gcp-9777
tseaver Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/system.py → tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@


USER_PROJECT = os.environ.get("GOOGLE_CLOUD_TESTS_USER_PROJECT")
DIRNAME = os.path.realpath(os.path.dirname(__file__))
DATA_DIRNAME = os.path.abspath(os.path.join(DIRNAME, "..", "data"))


def _bad_copy(bad_request):
Expand Down Expand Up @@ -451,11 +453,10 @@ def test_bucket_get_blob_with_user_project(self):

class TestStorageFiles(unittest.TestCase):

DIRNAME = os.path.realpath(os.path.dirname(__file__))
FILES = {
"logo": {"path": DIRNAME + "/data/CloudPlatform_128px_Retina.png"},
"big": {"path": DIRNAME + "/data/five-point-one-mb-file.zip"},
"simple": {"path": DIRNAME + "/data/simple.txt"},
"logo": {"path": DATA_DIRNAME + "/CloudPlatform_128px_Retina.png"},
"big": {"path": DATA_DIRNAME + "/five-point-one-mb-file.zip"},
"simple": {"path": DATA_DIRNAME + "/simple.txt"},
Comment on lines +457 to +459
Copy link
Contributor

@plamut plamut Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't that be an error on Windows that use a different path separator?

(the change itself is good, referring to the existing state here)

}

@classmethod
Expand Down