feat: Provide ensure_metadata and lookup_metadata_response calls#48
Merged
dazuma merged 1 commit intogoogleapis:mainfrom Oct 31, 2023
Merged
feat: Provide ensure_metadata and lookup_metadata_response calls#48dazuma merged 1 commit intogoogleapis:mainfrom
dazuma merged 1 commit intogoogleapis:mainfrom
Conversation
dazuma
force-pushed
the
pr/metadata-object
branch
6 times, most recently
from
af7078f to
2ca88cf
Compare
dazuma
changed the title
dazuma
force-pushed
the
pr/metadata-object
branch
from
2ca88cf to
013cead
Compare
dazuma
force-pushed
the
pr/metadata-object
branch
from
013cead to
aed16a6
Compare
| # The default host for the metadata server | ||
| # @return [String] | ||
| # | ||
| DEFAULT_HOST = "http://169.254.169.254" |
Member
There was a problem hiding this comment.
Why do we use IP instead of host_name ?
Contributor
Author
There was a problem hiding this comment.
To remove DNS as a source of failures and latency.
bajajneha27
approved these changes
Oct 31, 2023
dazuma
force-pushed
the
pr/metadata-object
branch
from
aed16a6 to
4d23364
Compare
dazuma
force-pushed
the
pr/metadata-object
branch
from
4d23364 to
1263bfa
Compare
dazuma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the second commit is relevant. The first is from #53.
This reworks the main Google::Cloud::Env class to use the accessor objects that have been implemented. It also:
Google::Cloud::Env#ensure_metadatawhich is referenced from the Google::Cloud::Env::MetadataServerNotResponding class in feat: Provide an access object for the metadata server #53.Google::Cloud::Env#lookup_metadata_responsewhich can be used to fetch access and identity tokens.