Skip to content

Conversation

@purva9413
Copy link
Contributor

@purva9413 purva9413 commented Jul 31, 2025

This PR adds in the ability to set ReadLockMode as a nested option under ReadWrite transaction options.

TESTED=All acceptance and unit tests pass

@purva9413 purva9413 requested review from a team as code owners July 31, 2025 22:16
@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2025
@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2025
Copy link
Contributor

@aandreassa aandreassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment on documentation. Could we add an integration test just to make sure the server is accepting the new argument?

@purva9413 purva9413 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2025
@purva9413 purva9413 requested a review from aandreassa August 13, 2025 22:00
@purva9413
Copy link
Contributor Author

Added a comment on documentation. Could we add an integration test just to make sure the server is accepting the new argument?

I have added in a do not merge tag which I will remove when we have the feature set up on the backend. Not sure if it makes sense adding integration tests for every new option we introduce in the client library for the purpose of testing whether the backend accepts it though. We can have one integration test (maybe in a seperate PR) to check all TransactionOptions are set and sent correctly to the backend. Thoughts?

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
Copy link
Contributor

@aandreassa aandreassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits!

Also, I am OK with adding a single integration test that sets fields in transaction options. Would it be difficult to do it in this PR?

It should be helpful to double check that we are sending the correct format for the request.

@purva9413 purva9413 requested a review from aandreassa December 3, 2025 23:11
@purva9413 purva9413 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 3, 2025
Copy link
Contributor

@aandreassa aandreassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@aandreassa aandreassa merged commit 36a0fe1 into googleapis:main Dec 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants