Allow sending request tags for snapshot queries #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This change extends the `request_options` functionality for request tags and query priority to queries issued against snapshots. This allows for the use of read-only transactions with staleness semantics but still bucketing queries via tags for analysis purposes.
michaelherold
force-pushed
the
michaelherold/request-tags-on-snapshots
branch
from
4a0601f to
bbac05a
Compare
Member
|
Can you please add the same for the |
Member
|
obsolete by #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the
request_optionsfunctionality for request tags and query priority to queries issued against snapshots. This allows for the use of read-only transactions with staleness semantics but still bucketing queries via tags for analysis purposes.bundle exec rake ciin the gem subdirectory.rake ciis broken even without this change so I'm not sure how to proceed.Closes #197