Don't route to leader for single-use transactions #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it so queries against single-use transactions do not route to the leader, even when leader-aware routing is enabled, as these single-use transactions are read-only transactions with specific staleness requirements.
michaelherold
commented
Nov 3, 2025
| gapic_options.metadata["x-goog-spanner-route-to-leader"] == 'true' | ||
| end | ||
| mock.expect :execute_streaming_sql, results_enum do |request, gapic_options| | ||
| gapic_options.metadata["x-goog-spanner-route-to-leader"] == 'false' |
Contributor
Author
There was a problem hiding this comment.
question: I'm unsure if "false" here or not emitting it would be better, but the helper specifies "false" so that's what I went with.
michaelherold
changed the title
viacheslav-rostovtsev
requested changes
Nov 4, 2025
| tag_type: :request_tag | ||
| single_use_tx = single_use_transaction single_use | ||
| route_to_leader = LARHeaders.execute_query true | ||
| route_to_leader = LARHeaders.execute_query !single_use_tx |
Member
There was a problem hiding this comment.
I am pretty sure it should be just false. If it's single-use (as specified by the caller) it's RO explicitly; if nil is specified by the caller, the default case for execute_streaming_sql is a "temporary read-only transaction with strong concurrency" https://github.com/googleapis/googleapis/blob/53af3b727f84acc34e31c23f3b6e7b8aa4b7e837/google/spanner/v1/spanner.proto#L716-L717
Member
|
obsolete by #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so queries against single-use transactions do not route to the leader, even when leader-aware routing is enabled, as these single-use transactions are read-only transactions with specific staleness requirements.
Checklist
Client#execute_queryalways routes to leader, even when unnecessary #196bundle exec rake ciin the gem subdirectory.mainfor meCloses #196