Skip to content

[ggj][engx] fix: move ServiceClientSampleCodeComposer to composer.samplecode #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 22, 2020
Merged

[ggj][engx] fix: move ServiceClientSampleCodeComposer to composer.samplecode #616

merged 20 commits into from
Dec 22, 2020

Conversation

@miraleung
Copy link
Contributor

@miraleung miraleung commented Dec 22, 2020

Ensure the logic/package structure stays consistent.

@miraleung
fix: fix dep ordering in Bazel dedupe rules
8bc63f4
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
43307c0
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
6a139fa
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
5db4adb
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
82d628d
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
1669fd6
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
06c7f46
@miraleung
Merge branch 'master' of github.com:googleapis/gapic-generator-java
ecfe117
@miraleung
Merge branch 'master' of github.com:googleapis/gapitc-generator-java
3f4b145
@miraleung
Merge remote-tracking branch 'origin/master'
0d92bec
@miraleung
fix: filter out unbound vars in HttpRuleParser
c2e56c1
@miraleung
fix: use nested types in message store key, filter out subtypes in ty…
a14a1b1 
…pestore
@miraleung
refactor: make TypeNode map a TypeStore class
af420ac
@miraleung
fix: remove superfluous varexpr helper in ServiceClientClassComposer
7a3f6c2
@miraleung
fix: move varexpr helper to local lambda for better locality
980e5bd
@miraleung
fix: move ServiceClientSampleCodeComposer to composer.samplecode
18737e1
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2020
@miraleung miraleung changed the base branch from dev/a4 to dev/a3 December 22, 2020 19:27
@miraleung miraleung changed the base branch from dev/a3 to dev/a4 December 22, 2020 19:46
Base automatically changed from dev/a4 to master December 22, 2020 20:36
@miraleung miraleung merged commit ccb299c into master Dec 22, 2020
@miraleung miraleung deleted the dev/a5 branch December 22, 2020 21:45
@summer-ji-eng summer-ji-eng mentioned this pull request Dec 31, 2020
Merged
summer-ji-eng added a commit that referenced this pull request Dec 31, 2020
@summer-ji-eng
rebase #616
3f19456
summer-ji-eng added a commit that referenced this pull request Jan 5, 2021
@summer-ji-eng
rebase #616
d752d07
summer-ji-eng added a commit that referenced this pull request Jan 6, 2021
@summer-ji-eng
[rebase][samplecode] rebase dev_composer and correct samplecode test …
9c2ad96 
…position (#628)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* Move ServiceClientSampleCodeComposerTest into correct dir

* rebase #616

* rebase samplecode with dev_composer
summer-ji-eng added a commit that referenced this pull request Jan 6, 2021
@summer-ji-eng
rebase #616
04c6c25
summer-ji-eng added a commit that referenced this pull request Jan 13, 2021
@summer-ji-eng
rebase #616
89429f6
summer-ji-eng added a commit that referenced this pull request Jan 15, 2021
@summer-ji-eng
[rebase][samplecode] rebase dev_composer and correct samplecode test …
0e32cf4 
…position (#628)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* Move ServiceClientSampleCodeComposerTest into correct dir

* rebase #616

* rebase samplecode with dev_composer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@summer-ji-eng summer-ji-eng summer-ji-eng approved these changes

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miraleung @summer-ji-eng @xiaozhenliu-gg5