Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Conversation

nitag
Copy link
Contributor

@nitag nitag commented Mar 9, 2016

Integration test for IdentityByState (issue 70)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nitag nitag changed the title Create IdentityByStateITCase.java Add integration test for IdentityByState Mar 9, 2016
@nitag
Copy link
Contributor Author

nitag commented Mar 9, 2016

Fixes #70

@nitag
Copy link
Contributor Author

nitag commented Mar 9, 2016

I signed it.

On Tue, Mar 8, 2016 at 10:36 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#174 (comment)
.

Regards,
Nita

}

@Test
public void testStreamingLocal() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useGrpc isn't actually an argument to this pipeline, are you able to successfully run this test?

I get error java.lang.IllegalArgumentException: Class interface com.google.cloud.genomics.dataflow.pipelines.IdentityByState$Options missing a property named 'useGrpc'. when I run it.

Also I found I needed to do the following when I ran into this issue:
(1) grab a more recent version of alpn and stick it in ./lib
(2) update the activation section in pom.xml to use the newer version

@deflaux
Copy link
Contributor

deflaux commented Mar 10, 2016

@nitag this is definitely on the right track, thank you!

@nitag
Copy link
Contributor Author

nitag commented Mar 16, 2016

Thanks for the comments. Submitting a new pull request with the merged changes.

@nitag nitag closed this Mar 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants