feat: Use version catalog for dependency management #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
force-pushed
the
feature/version-catalog
branch
2 times, most recently
from
4a6b6f5 to
5b84f6f
Compare
oas004
force-pushed
the
feature/version-catalog
branch
from
5b84f6f to
f54882f
Compare
Contributor
Author
|
@barbeau There is always one UI test that is failing, it runs green locally. Is it just a flaky test? Or is there something I can do to optimise this? 🤔 😄 |
Contributor
Contributor
Author
arriolac
approved these changes
Aug 17, 2022
Contributor
arriolac
left a comment
arriolac
left a comment
There was a problem hiding this comment.
This change looks great btw! It LGTM. Still need to figure out the flaky test but I think this should be good to merge so long as tests pass locally.
wangela
approved these changes
Aug 17, 2022
googlemaps-bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
# [2.6.0](v2.5.3...v2.6.0) (2022-08-17) ### Features * Use version catalog for dependency management ([#185](#185)) ([b2b33ab](b2b33ab))
Contributor
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for an awesome project! 🤩 I really like it!
In this PR I have tried to implement version catalog for dependency management. This is important to ensure consistency in library versions across modules.
There are some things to consider. The AGP version is not yet updated (7.0.4) and therefore [version catalog](https://docs.gradle.org/current/userguide/platforms.html) is still experimental. However, since there was a PR onthis (181) I thought this was okay. Then I canrebase and remove theenableFeaturePreviewflag when that is merged. Furthermore, I have notimplementedpluginsinlibrary.versions.tomlas that is a feature that was added in version 7.2 of gradle.Update: Rebased on #181, used plugins from version catalog and updated the root gradle file 😄
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #172 🦕
Fixes #160 🦕