feat: Allow changes to animation duration for marker splitting/merging effects #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for marker splitting/merging effects
barbeau
requested changes
Jun 27, 2022
library/src/main/java/com/google/maps/android/clustering/view/ClusterRenderer.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/google/maps/android/clustering/view/ClusterRenderer.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/google/maps/android/clustering/view/DefaultClusterRenderer.java
Show resolved
Hide resolved
library/src/main/java/com/google/maps/android/clustering/view/DefaultClusterRenderer.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/google/maps/android/clustering/view/DefaultClusterRenderer.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/google/maps/android/clustering/view/ClusterRenderer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Barbeau <sjbarbeau@gmail.com>
Co-authored-by: Sean Barbeau <sjbarbeau@gmail.com>
Contributor
Author
|
@barbeau. Fixed all comments. Long everywhere for animation duration and Javadocs to interface method and to class method |
barbeau
changed the title
barbeau
reviewed
Jun 28, 2022
| * @param animationDuration long: The length of the animation, in milliseconds. This value cannot be negative. | ||
| */ | ||
| @Override | ||
| public void setAnimationDuration(long animationDuration) { |
Collaborator
There was a problem hiding this comment.
One last item - can you please change all the variables here to add the Ms suffix? For example, animationDurationMs, mAnimationDurationMs.
barbeau
approved these changes
Jun 28, 2022
googlemaps-bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
# [2.4.0](v2.3.0...v2.4.0) (2022-06-28) ### Features * Allow changes to animation duration for marker splitting/merging effects ([#1098](#1098)) ([1930f6a](1930f6a))
Contributor
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My implementation of my feature request - issue#1097
Closes #1097