Skip to content

fix: Copy drawables to drawable-xxxhdpi #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix: Copy drawables to drawable-xxxhdpi #856

merged 1 commit into from
Apr 16, 2021

Conversation

@barbeau
Copy link
Collaborator

@barbeau barbeau commented Apr 15, 2021 •
edited
Loading

Attempt to fix Resources$NotFoundException on xxxhdpi displays such as the Galaxy S21 Ultra 5G, as discussed in #532 (comment).

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/

Fixes #532 🦕

@barbeau barbeau requested a review from arriolac April 15, 2021 19:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2021
@barbeau barbeau mentioned this pull request Apr 15, 2021
Closed
@barbeau barbeau merged commit 8b55e18 into main Apr 16, 2021
@barbeau barbeau deleted the sean/xxxhdpi-drawables branch April 16, 2021 17:38
googlemaps-bot pushed a commit that referenced this pull request Apr 28, 2021
@semantic-release-bot
chore(release): 2.2.3 [skip ci]
342cc20 
## [2.2.3](v2.2.2...v2.2.3) (2021-04-28)

### Bug Fixes

* Copy drawables to drawable-xxxhdpi ([#856](#856)) ([8b55e18](8b55e18)), closes [#532](#532)
* Fix MultipleArtifactsNotFoundException ([1d0e062](1d0e062))
@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Apr 28, 2021

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arriolac arriolac arriolac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arriolac arriolac

Labels

cla: yes This human has signed the Contributor License Agreement. released on @chris/fix/858

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fatal Exception: android.content.res.Resources$NotFoundException: Resource ID

3 participants

@barbeau @googlemaps-bot @arriolac